[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 08/13] block: Support meta dirty bitmap
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-block] [PATCH v2 08/13] block: Support meta dirty bitmap |
|
Date: |
Tue, 26 Jan 2016 12:31:08 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, 01/22 14:34, Vladimir Sementsov-Ogievskiy wrote:
> >+void bdrv_create_meta_dirty_bitmap(BdrvDirtyBitmap *bitmap,
> >+ int granularity)
> >+{
> >+ assert(!bitmap->meta);
> >+ bitmap->meta = hbitmap_create_meta(bitmap->bitmap,
> >+ BDRV_SECTOR_SIZE * BITS_PER_BYTE);
> >+}
>
> what is granularity here? Is it unused?
>
> Here should be chunk_size parameter, which then will be somehow send
> to hbitmap_create_meta.
Right, it should replace BDRV_SECTOR_SIZE.
Fam
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap, (continued)
- [Qemu-block] [PATCH v2 03/13] block: Move block dirty bitmap code to separate files, Fam Zheng, 2016/01/20
- [Qemu-block] [PATCH v2 04/13] block: Remove unused typedef of BlockDriverDirtyHandler, Fam Zheng, 2016/01/20
- [Qemu-block] [PATCH v2 05/13] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/01/20
- [Qemu-block] [PATCH v2 06/13] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/01/20
- [Qemu-block] [PATCH v2 07/13] tests: Add test code for meta bitmap, Fam Zheng, 2016/01/20
- [Qemu-block] [PATCH v2 08/13] block: Support meta dirty bitmap, Fam Zheng, 2016/01/20
Re: [Qemu-block] [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap, John Snow, 2016/01/25
[Qemu-block] [PATCH v2 09/13] block: Add two dirty bitmap getters, Fam Zheng, 2016/01/20
[Qemu-block] [PATCH v2 10/13] block: Assert that bdrv_release_dirty_bitmap succeeded, Fam Zheng, 2016/01/20