[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 07/10] qemu-img: allow specifying image as a
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v4 07/10] qemu-img: allow specifying image as a set of options args |
Date: |
Wed, 27 Jan 2016 15:30:29 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben:
> Currently qemu-img allows an image filename to be passed on the
> command line, but unless using the JSON format, it does not have
> a way to set any options except the format eg
>
> qemu-img info https://127.0.0.1/images/centos7.iso
>
> This adds a --image-opts arg that indicates that the positional
> filename should be interpreted as a full option string, not
> just a filename.
>
> qemu-img info --source
> driver=http,url=https://127.0.0.1/images,sslverify=off
>
> This flag is mutually exclusive with the '-f' / '-F' flags.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> @@ -633,7 +671,20 @@ static int img_check(int argc, char **argv)
> return 1;
> }
>
> - blk = img_open("image", filename, fmt, flags, true, quiet);
> + if (image_opts) {
> + if (fmt) {
> + error_report("--image-opts and --format are mutually exclusive");
> + exit(1);
> + }
> + opts = qemu_opts_parse_noisily(qemu_find_opts("source"),
> + filename, true);
> + if (!opts) {
> + exit(1);
> + }
> + blk = img_open_opts("image", opts, flags);
> + } else {
> + blk = img_open_file("image", filename, fmt, flags, true, quiet);
> + }
This block is duplicated everywhere. Can you make it a function so that
it stays a single line in each of the callers?
Kevin
- Re: [Qemu-block] [PATCH v4 03/10] qemu-nbd: add support for --object command line arg, (continued)
- [Qemu-block] [PATCH v4 04/10] qemu-io: add support for --object command line arg, Daniel P. Berrange, 2016/01/26
- [Qemu-block] [PATCH v4 02/10] qemu-img: add support for --object command line arg, Daniel P. Berrange, 2016/01/26
- [Qemu-block] [PATCH v4 06/10] qemu-nbd: allow specifying image as a set of options args, Daniel P. Berrange, 2016/01/26
- [Qemu-block] [PATCH v4 05/10] qemu-io: allow specifying image as a set of options args, Daniel P. Berrange, 2016/01/26
- [Qemu-block] [PATCH v4 08/10] qemu-nbd: don't overlap long option values with short options, Daniel P. Berrange, 2016/01/26
- [Qemu-block] [PATCH v4 10/10] qemu-io: use no_argument/required_argument constants, Daniel P. Berrange, 2016/01/26
- [Qemu-block] [PATCH v4 07/10] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2016/01/26
- Re: [Qemu-block] [PATCH v4 07/10] qemu-img: allow specifying image as a set of options args,
Kevin Wolf <=
- [Qemu-block] [PATCH v4 09/10] qemu-nbd: use no_argument/required_argument constants, Daniel P. Berrange, 2016/01/26