Re: [Qemu-block] [PATCH v2 0/3] blockjob: correct backup cluster size for backups

[Stefan Hajnoczi]

On Mon, Feb 22, 2016 at 05:07:04PM -0500, John Snow wrote:
> Backups sometimes need a non-64KiB transfer cluster size.
> See patch #2 for the detailed justificaton.
> 
> ===
> v2
> ===
> 
> 01: Removed "sectors_per_cluster" as a cached property of the Backup Block 
> Job,
>     In favor of recomputing it with a small function where needed.
>     (I like v1 more. Thoughts?)
> 02: Expand correction to all backup modes instead of just incremental.
>     Added credit: Thanks to Fam Z for noticing this problem!
> 03: Minor phrasing change in a comment.
>     Added r-b.
> 
> ________________________________________________________________________________
> 
> For convenience, this branch is available at:
> https://github.com/jnsnow/qemu.git branch incremental-granularity-fix
> https://github.com/jnsnow/qemu/tree/incremental-granularity-fix
> 
> This version is tagged incremental-granularity-fix-v2:
> https://github.com/jnsnow/qemu/releases/tag/incremental-granularity-fix-v2
> 
> John Snow (3):
>   block/backup: make backup cluster size configurable
>   block/backup: avoid copying less than full target clusters
>   iotests/124: Add cluster_size mismatch test
> 
>  block/backup.c             | 72 
> ++++++++++++++++++++++++++++------------------
>  tests/qemu-iotests/124     | 58 +++++++++++++++++++++++++++++++++----
>  tests/qemu-iotests/124.out |  4 +--
>  3 files changed, 99 insertions(+), 35 deletions(-)

Please CC Jeff Cody.  He maintains block jobs.

Thanks,
Stefan

signature.asc
Description: PGP signature