[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 13/16] block: only call aio_poll fr
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 13/16] block: only call aio_poll from iothread |
|
Date: |
Wed, 9 Mar 2016 17:27:30 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 03/09 10:10, Paolo Bonzini wrote:
>
>
> On 09/03/2016 09:30, Fam Zheng wrote:
> > > - aio_poll(bdrv_get_aio_context(bs), true);
> > > + if (aio_context_in_iothread(ctx)) {
> > > + /* This case should not occur at all, except for the
> > > + * main thread.
> > > + */
> >
> > Maybe assert ctx == qemu_get_aio_context()?
>
> Actually it happens for block/mirror.c's bdrv_drained_begin, but it's safe.
Oh yes, then we cannot assert, and the comment need adjustion. Thanks for
pointing out.
Fam