[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] block: Fix memory leak in hmp_driv
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] block: Fix memory leak in hmp_drive_add_node() |
Date: |
Wed, 16 Mar 2016 13:26:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> hmp_drive_add_node() leaked qdict in the error path when no node-name is
> specified.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index e7b8676..50410bf 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -3898,6 +3898,7 @@ void hmp_drive_add_node(Monitor *mon, const char
> *optstr)
> qdict = qemu_opts_to_qdict(opts, NULL);
>
> if (!qdict_get_try_str(qdict, "node-name")) {
> + QDECREF(qdict);
> error_report("'node-name' needs to be specified");
> goto out;
> }
Reviewed-by: Markus Armbruster <address@hidden>