[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/e
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end |
Date: |
Wed, 30 Mar 2016 14:24:55 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 24 Mar 2016 05:39:23 PM CET, Paolo Bonzini wrote:
> Extract the handling of throttling from bdrv_flush_io_queue. These
> new functions will soon become BdrvChildRole callbacks, as they can
> be generalized to "beginning of drain" and "end of drain".
>
> Signed-off-by: Paolo Bonzini <address@hidden>
I like the idea, thanks for the patch!
Reviewed-by: Alberto Garcia <address@hidden>
> +void bdrv_no_throttling_end(BlockDriverState *bs)
> +{
> + --bs->io_limits_disabled;
> }
Not very important, but you could assert that this doesn't go below 0.
Berto
- [Qemu-block] [PATCH v3 0/7] bdrv_flush_io_queue removal, shared LinuxAioState, Paolo Bonzini, 2016/03/24
- [Qemu-block] [PATCH 1/7] block: Don't disable I/O throttling on sync requests, Paolo Bonzini, 2016/03/24
- [Qemu-block] [PATCH 2/7] block: make bdrv_start_throttled_reqs return void, Paolo Bonzini, 2016/03/24
- [Qemu-block] [PATCH 5/7] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end, Paolo Bonzini, 2016/03/24
- [Qemu-block] [PATCH 6/7] linux-aio: make it more type safe, Paolo Bonzini, 2016/03/24
- [Qemu-block] [PATCH 3/7] block: move restarting of throttled reqs to block/throttle-groups.c, Paolo Bonzini, 2016/03/24
- [Qemu-block] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end, Paolo Bonzini, 2016/03/24
- Re: [Qemu-block] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end,
Alberto Garcia <=
- [Qemu-block] [PATCH 7/7] linux-aio: share one LinuxAioState within an AioContext, Paolo Bonzini, 2016/03/24
- Re: [Qemu-block] [PATCH v3 0/7] bdrv_flush_io_queue removal, shared LinuxAioState, Stefan Hajnoczi, 2016/03/30