[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__
From: |
Sascha Silbe |
Subject: |
[Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__ |
Date: |
Tue, 5 Apr 2016 11:21:49 +0200 |
The __all__ list contained a typo for as long as the iotests module
existed. That typo prevented "from iotests import *" (which is the
only case where iotests.__all__ is used at all) from ever working.
The names used by iotests are highly prone to name collisions, so
importing them all unconditionally is a bad idea anyway. Since __all__
is not adding any value, let's just get rid of it.
Fixes: f345cfd0 ("qemu-iotests: add iotests Python module")
Signed-off-by: Sascha Silbe <address@hidden>
Reviewed-by: Bo Tu <address@hidden>
---
tests/qemu-iotests/iotests.py | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index bf31ec8..0c0b533 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -29,10 +29,6 @@ import qmp
import qtest
import struct
-__all__ = ['imgfmt', 'imgproto', 'test_dir' 'qemu_img', 'qemu_io',
- 'VM', 'QMPTestCase', 'notrun', 'main', 'verify_image_format',
- 'verify_platform', 'filter_test_dir', 'filter_win32',
- 'filter_qemu_io', 'filter_chown', 'log']
# This will not work if arguments contain spaces but is necessary if we
# want to support the override options that ./check supports.
--
1.9.1
- [Qemu-block] [PATCH 0/7] next round of qemu-iotests fixes, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 5/7] qemu-iotests: 068: don't require KVM, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__,
Sascha Silbe <=
- [Qemu-block] [PATCH 2/7] qemu-iotests: fix 051 on non-PC architectures, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 1/7] qemu-iotests: check: don't place files with predictable names in /tmp, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Sascha Silbe, 2016/04/05