[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH for-2.6 1/2] block/gluster: return correct error val
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PATCH for-2.6 1/2] block/gluster: return correct error value |
Date: |
Tue, 5 Apr 2016 23:29:51 -0400 |
Upon error, gluster will call the aio callback function with a
ret value of -1, with errno set to the proper error value. If
we set the acb->ret value to the return value in the callback,
that results in every error being EPERM (i.e. 1). Instead, set
it to the proper error result.
Signed-off-by: Jeff Cody <address@hidden>
---
block/gluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/gluster.c b/block/gluster.c
index 7bface2..30a827e 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -245,7 +245,7 @@ static void gluster_finish_aiocb(struct glfs_fd *fd,
ssize_t ret, void *arg)
if (!ret || ret == acb->size) {
acb->ret = 0; /* Success */
} else if (ret < 0) {
- acb->ret = ret; /* Read/Write failed */
+ acb->ret = -errno; /* Read/Write failed */
} else {
acb->ret = -EIO; /* Partial read/write - fail it */
}
--
1.9.3
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, (continued)
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Ric Wheeler, 2016/04/06
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Kevin Wolf, 2016/04/06
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Kevin Wolf, 2016/04/06
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Jeff Cody, 2016/04/06
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Kevin Wolf, 2016/04/06
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Pranith Kumar Karampuri, 2016/04/07
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Raghavendra Gowdappa, 2016/04/11
- Re: [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error, Jeff Cody, 2016/04/07
[Qemu-block] [PATCH for-2.6 1/2] block/gluster: return correct error value,
Jeff Cody <=