qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp


From: Sascha Silbe
Subject: [Qemu-block] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp
Date: Tue, 12 Apr 2016 16:56:16 +0200

During review of my other qemu-iotests fixes, Max Reitz noticed a
couple of additional places where qemu-iotests hardcode /tmp. This is
both a security issue and cumbersome when running multiple instances
of qemu-iotests (e.g. different users on a shared development machine
like tuxmaker). Fix them up.

Checked (/var)/tmp usage using "sudo chown 000 /tmp /var/tmp". "tac"
and "qemu -snapshot" fail in that case. I'll presume they create the
temporary files in a secure manner.

There is one place left that may use /var/tmp in theory; will address
that in a separate patch.

This series mostly removes dead code and addresses a potential
security issue, all of that in the test suite rather than in
production code. It should be applicable even during hard freeze.
 

Sascha Silbe (4):
  qemu-iotests: drop unused _within_tolerance() filter
  qemu-iotests: common.rc: drop unused _do()
  qemu-iotests: tests: do not set unused tmp variable
  qemu-iotests: place valgrind log file in scratch dir

 tests/qemu-iotests/001           |   1 -
 tests/qemu-iotests/002           |   1 -
 tests/qemu-iotests/003           |   1 -
 tests/qemu-iotests/004           |   1 -
 tests/qemu-iotests/005           |   1 -
 tests/qemu-iotests/007           |   1 -
 tests/qemu-iotests/008           |   1 -
 tests/qemu-iotests/009           |   1 -
 tests/qemu-iotests/010           |   1 -
 tests/qemu-iotests/011           |   1 -
 tests/qemu-iotests/012           |   1 -
 tests/qemu-iotests/013           |   1 -
 tests/qemu-iotests/014           |   1 -
 tests/qemu-iotests/015           |   1 -
 tests/qemu-iotests/017           |   1 -
 tests/qemu-iotests/018           |   1 -
 tests/qemu-iotests/019           |   1 -
 tests/qemu-iotests/020           |   1 -
 tests/qemu-iotests/021           |   1 -
 tests/qemu-iotests/022           |   1 -
 tests/qemu-iotests/023           |   1 -
 tests/qemu-iotests/024           |   1 -
 tests/qemu-iotests/025           |   1 -
 tests/qemu-iotests/026           |   1 -
 tests/qemu-iotests/027           |   1 -
 tests/qemu-iotests/028           |   1 -
 tests/qemu-iotests/029           |   1 -
 tests/qemu-iotests/031           |   1 -
 tests/qemu-iotests/032           |   1 -
 tests/qemu-iotests/033           |   1 -
 tests/qemu-iotests/034           |   1 -
 tests/qemu-iotests/035           |   1 -
 tests/qemu-iotests/036           |   1 -
 tests/qemu-iotests/037           |   1 -
 tests/qemu-iotests/038           |   1 -
 tests/qemu-iotests/039           |   1 -
 tests/qemu-iotests/042           |   1 -
 tests/qemu-iotests/043           |   1 -
 tests/qemu-iotests/046           |   1 -
 tests/qemu-iotests/047           |   1 -
 tests/qemu-iotests/049           |   1 -
 tests/qemu-iotests/050           |   1 -
 tests/qemu-iotests/051           |   1 -
 tests/qemu-iotests/052           |   1 -
 tests/qemu-iotests/053           |   1 -
 tests/qemu-iotests/054           |   1 -
 tests/qemu-iotests/058           |   1 -
 tests/qemu-iotests/059           |   1 -
 tests/qemu-iotests/060           |   1 -
 tests/qemu-iotests/061           |   1 -
 tests/qemu-iotests/062           |   1 -
 tests/qemu-iotests/063           |   1 -
 tests/qemu-iotests/064           |   1 -
 tests/qemu-iotests/066           |   1 -
 tests/qemu-iotests/067           |   1 -
 tests/qemu-iotests/068           |   1 -
 tests/qemu-iotests/069           |   1 -
 tests/qemu-iotests/070           |   1 -
 tests/qemu-iotests/071           |   1 -
 tests/qemu-iotests/072           |   1 -
 tests/qemu-iotests/073           |   1 -
 tests/qemu-iotests/075           |   1 -
 tests/qemu-iotests/076           |   1 -
 tests/qemu-iotests/077           |   1 -
 tests/qemu-iotests/078           |   1 -
 tests/qemu-iotests/079           |   1 -
 tests/qemu-iotests/080           |   1 -
 tests/qemu-iotests/081           |   1 -
 tests/qemu-iotests/082           |   1 -
 tests/qemu-iotests/083           |   1 -
 tests/qemu-iotests/084           |   1 -
 tests/qemu-iotests/086           |   1 -
 tests/qemu-iotests/087           |   1 -
 tests/qemu-iotests/088           |   1 -
 tests/qemu-iotests/089           |   1 -
 tests/qemu-iotests/090           |   1 -
 tests/qemu-iotests/092           |   1 -
 tests/qemu-iotests/094           |   1 -
 tests/qemu-iotests/097           |   1 -
 tests/qemu-iotests/098           |   1 -
 tests/qemu-iotests/099           |   1 -
 tests/qemu-iotests/100           |   1 -
 tests/qemu-iotests/101           |   1 -
 tests/qemu-iotests/102           |   1 -
 tests/qemu-iotests/103           |   1 -
 tests/qemu-iotests/104           |   1 -
 tests/qemu-iotests/105           |   1 -
 tests/qemu-iotests/107           |   1 -
 tests/qemu-iotests/108           |   1 -
 tests/qemu-iotests/109           |   1 -
 tests/qemu-iotests/110           |   1 -
 tests/qemu-iotests/111           |   1 -
 tests/qemu-iotests/112           |   1 -
 tests/qemu-iotests/113           |   1 -
 tests/qemu-iotests/114           |   1 -
 tests/qemu-iotests/115           |   1 -
 tests/qemu-iotests/116           |   1 -
 tests/qemu-iotests/117           |   1 -
 tests/qemu-iotests/119           |   1 -
 tests/qemu-iotests/120           |   1 -
 tests/qemu-iotests/121           |   1 -
 tests/qemu-iotests/122           |   1 -
 tests/qemu-iotests/123           |   1 -
 tests/qemu-iotests/128           |   1 -
 tests/qemu-iotests/130           |   1 -
 tests/qemu-iotests/131           |   1 -
 tests/qemu-iotests/133           |   1 -
 tests/qemu-iotests/134           |   1 -
 tests/qemu-iotests/135           |   1 -
 tests/qemu-iotests/137           |   1 -
 tests/qemu-iotests/138           |   1 -
 tests/qemu-iotests/140           |   1 -
 tests/qemu-iotests/141           |   1 -
 tests/qemu-iotests/142           |   1 -
 tests/qemu-iotests/143           |   1 -
 tests/qemu-iotests/145           |   1 -
 tests/qemu-iotests/150           |   1 -
 tests/qemu-iotests/common.config |   2 +-
 tests/qemu-iotests/common.filter | 101 ---------------------------------------
 tests/qemu-iotests/common.rc     |  46 ------------------
 120 files changed, 1 insertion(+), 265 deletions(-)

-- 
1.9.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]