[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/2] vvfat: Fix default volume l
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/2] vvfat: Fix default volume label |
Date: |
Thu, 28 Apr 2016 20:30:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Commit d5941dd documented that it leaves the default volume name as it
> was ("QEMU VVFAT"), but it doesn't actually implement this. You get an
> empty name (eleven space characters) instead.
Hrmph.
> This fixes the implementation to apply the advertised default.
>
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> block/vvfat.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index ff3df35..183fc4f 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1109,6 +1109,8 @@ static int vvfat_open(BlockDriverState *bs, QDict
> *options, int flags,
> goto fail;
> }
> memcpy(s->volume_label, label, label_length);
> + } else {
> + memcpy(s->volume_label, "QEMU VVFAT", 10);
> }
>
> if (floppy) {
Reviewed-by: Markus Armbruster <address@hidden>