qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v13 2/3] quorum: implement bdrv_add_child() and


From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()
Date: Tue, 10 May 2016 10:45:10 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Tue 10 May 2016 10:39:21 AM CEST, Kevin Wolf wrote:
>>        s->children = g_renew(BdrvChild *, s->children, ++s->num_children);
>>        s->children[s->num_children] = child;
>
> Without having checked the context, this code is not equivalent. You
> need to access s->children[s->num_children - 1] now in the second
> line.

Yeah, you are both right, sorry for the mistake!

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]