[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v4 10/11] nbd: Detect servers that send unexpected e
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v4 10/11] nbd: Detect servers that send unexpected error values |
Date: |
Wed, 11 May 2016 16:39:43 -0600 |
Add some debugging to flag servers that are not compliant to
the NBD protocol. This would have flagged the server bug
fixed in commit c0301fcc.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Alex Bligh <address@hidden>
---
v3: later in series, but no change
---
nbd/client.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/nbd/client.c b/nbd/client.c
index 937344c..4659df3 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -33,8 +33,10 @@ static int nbd_errno_to_system_errno(int err)
return ENOMEM;
case NBD_ENOSPC:
return ENOSPC;
+ default:
+ TRACE("Squashing unexpected error %d to EINVAL", err);
+ /* fallthrough */
case NBD_EINVAL:
- default:
return EINVAL;
}
}
--
2.5.5
- [Qemu-block] [PATCH v4 00/11] nbd: tighter protocol compliance, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 03/11] nbd: Quit server after any write error, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 02/11] nbd: More debug typo fixes, use correct formats, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 05/11] nbd: Reject unknown request flags, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 11/11] nbd: Avoid magic number for NBD max name size, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 01/11] nbd: Use BDRV_REQ_FUA for better FUA where supported, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 10/11] nbd: Detect servers that send unexpected error values,
Eric Blake <=
- [Qemu-block] [PATCH v4 06/11] nbd: Group all Linux-specific ioctl code in one place, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 08/11] nbd: Limit nbdflags to 16 bits, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Eric Blake, 2016/05/11
- [Qemu-block] [PATCH v4 07/11] nbd: Clean up ioctl handling of qemu-nbd -c, Eric Blake, 2016/05/11
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance, Alex Bligh, 2016/05/12