[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio bl
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access |
Date: |
Thu, 12 May 2016 13:26:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 12/05/2016 13:25, Paolo Bonzini wrote:
>> > r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg,
>> > r->sector,
>> > scsi_dma_complete, r);
> This is broken, it should be changed to an offset in the previous patch.
>
> Please rename the function too, so that it is obvious that you have
> changed all callers.
Oh, dma_blk_read is still sector-based...
Paolo
- [Qemu-block] [PATCH v7 00/19] block: kill sector-based blk_write/read, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 07/19] virtio: Switch to byte-based aio block access, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 09/19] fdc: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 11/19] onenand: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 15/19] atapi: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 16/19] nbd: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 17/19] qemu-img: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 18/19] qemu-io: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 19/19] block: Kill unused sector-based blk_* functions, Eric Blake, 2016/05/06
- [Qemu-block] [PATCH v7 02/19] block: Switch blk_read_unthrottled() to byte interface, Eric Blake, 2016/05/06