[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v5 17/27] block: Don't lock drive-backup target imag
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH v5 17/27] block: Don't lock drive-backup target image in none mode |
Date: |
Tue, 17 May 2016 15:35:26 +0800 |
As a very special case, in sync=none mode, the source, as the backing
image of the target, will be RO opened again, which is not accepted by
image locking because the first open could be exclusive.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 0784c4a..250e3d2 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3252,6 +3252,11 @@ static void do_drive_backup(const char *device, const
char *target,
}
}
if (sync == MIRROR_SYNC_MODE_NONE) {
+ /* XXX: bs will be open second time as the backing file of target,
+ * disable image locking. Once block layer allows sharing backing BDS,
+ * Change below to BDRV_O_NO_BACKING and assign it after bdrv_open().
+ * */
+ flags |= BDRV_O_NO_LOCK;
source = bs;
}
--
2.8.2
- [Qemu-block] [PATCH v5 13/27] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, (continued)
- [Qemu-block] [PATCH v5 13/27] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 15/27] qemu-img: Update documentation of "-L" option, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 16/27] qemu-nbd: Add "--no-lock/-L" option, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 14/27] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 18/27] mirror: Disable image locking on target backing chain, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 17/27] block: Don't lock drive-backup target image in none mode,
Fam Zheng <=
- [Qemu-block] [PATCH v5 19/27] qemu-iotests: 140: Disable image lock for qemu-io access, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 21/27] qemu-iotests: Wait for QEMU processes before checking image in 091, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 20/27] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 23/27] iotests: 087: Disable image lock in cases where file is shared, Fam Zheng, 2016/05/17