[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 6/7] scsi-disk: introduce scsi_disk
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 6/7] scsi-disk: introduce scsi_disk_req_check_error |
Date: |
Mon, 23 May 2016 13:16:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/23/2016 06:54 AM, Paolo Bonzini wrote:
> Commonize all the checks for canceled requests and errors. The next patch
> will add another case to check for, in order to handle passthrough commands.
>
> There is no semantic change here; the only nontrivial modification is in
> scsi_write_do_fua, where cancellation has been checked earlier by both
> callers. Thus, the check is replaced with an assertion.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/scsi/scsi-disk.c | 89
> +++++++++++++----------------------------------------
> 1 file changed, 22 insertions(+), 67 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 5/7] scsi-disk: add need_fua_emulation to SCSIDiskClass, (continued)
- [Qemu-block] [PATCH 1/7] dma-helpers: change interface to byte-based, Paolo Bonzini, 2016/05/23
- [Qemu-block] [PATCH 3/7] scsi-disk: introduce a common base class, Paolo Bonzini, 2016/05/23
- [Qemu-block] [PATCH 4/7] scsi-disk: introduce dma_readv and dma_writev, Paolo Bonzini, 2016/05/23
- [Qemu-block] [PATCH 6/7] scsi-disk: introduce scsi_disk_req_check_error, Paolo Bonzini, 2016/05/23
- Re: [Qemu-block] [Qemu-devel] [PATCH 6/7] scsi-disk: introduce scsi_disk_req_check_error,
Eric Blake <=
- [Qemu-block] [PATCH 7/7] scsi-block: always use SG_IO, Paolo Bonzini, 2016/05/23
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/7] dma-helpers, scsi-block: use SG_IO for all I/O on scsi-block, Mark Cave-Ayland, 2016/05/23
Re: [Qemu-block] [PATCH v2 0/7] dma-helpers, scsi-block: use SG_IO for all I/O on scsi-block, Kevin Wolf, 2016/05/25