Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] block: Make bdrv_drain() use bdrv_drained_begin/end()

[Eric Blake]

On 05/23/2016 10:55 AM, Kevin Wolf wrote:
> Until now, bdrv_drained_begin() used bdrv_drain() internally to drain
> the queue. This is kind of backwards and caused quiescing code to be
> duplicated because bdrv_drained_begin() had to ensure that no new
> requests come in even after bdrv_drain() returns, whereas bdrv_drain()
> had to have them because it could be called from other places.
> 
> Instead move the bdrv_drain() code to bdrv_drained_begin() and make
> bdrv_drain() a simple wrapper around bdrv_drained_begin/end().
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/io.c | 69 
> ++++++++++++++++++++++++++++++--------------------------------
>  1 file changed, 33 insertions(+), 36 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature