Re: [Qemu-block] [PATCH v5 25/27] tests: Use null-co:// instead of /dev/null

[Max Reitz]

On 17.05.2016 09:35, Fam Zheng wrote:
> With image locking, opening /dev/null can fail when multiple tests run
> in parallel (make -j2, for example). Use null-co:// as the null protocol
> doesn't do image locking.
> 
> While it's arguable we could special-case /dev/null, /dev/zero,
> /dev/urandom etc in raw-posix driver, it is not really necessary because
> user can always specify lock-mode=off when it is appropriate. So let's
> write sensible testing code too.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  tests/drive_del-test.c    | 2 +-
>  tests/nvme-test.c         | 2 +-
>  tests/usb-hcd-uhci-test.c | 2 +-
>  tests/usb-hcd-xhci-test.c | 2 +-
>  tests/virtio-blk-test.c   | 2 +-
>  tests/virtio-scsi-test.c  | 4 ++--
>  6 files changed, 7 insertions(+), 7 deletions(-)

I prefer a plain driver=null-co instead of file=null-co://,format=raw,
but whatever floats your boat.

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature