[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 01/15] block: Rename blk_write_zeroes()
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 01/15] block: Rename blk_write_zeroes() |
Date: |
Wed, 25 May 2016 16:40:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 25.05.2016 14:29, Kevin Wolf wrote:
> From: Eric Blake <address@hidden>
>
> Commit 983a1600 changed the semantics of blk_write_zeroes() to
> be byte-based rather than sector-based, but did not change the
> name, which is an open invitation for other code to misuse the
> function. Renaming to pwrite_zeroes() makes it more in line
> with other byte-based interfaces, and will help make it easier
> to track which remaining write_zeroes interfaces still need
> conversion.
>
> Reported-by: Kevin Wolf <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/block-backend.c | 14 +++++++-------
> block/parallels.c | 4 ++--
> hw/scsi/scsi-disk.c | 2 +-
> include/sysemu/block-backend.h | 14 +++++++-------
> qemu-img.c | 4 ++--
> qemu-io-cmds.c | 22 +++++++++++-----------
> 6 files changed, 30 insertions(+), 30 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 00/15] block jobs: Convert I/O to BlockBackend, Kevin Wolf, 2016/05/25
- [Qemu-block] [PATCH v3 02/15] block: keep a list of block jobs, Kevin Wolf, 2016/05/25
- [Qemu-block] [PATCH v3 03/15] block: Cancel jobs first in bdrv_close_all(), Kevin Wolf, 2016/05/25
- [Qemu-block] [PATCH v3 01/15] block: Rename blk_write_zeroes(), Kevin Wolf, 2016/05/25
- Re: [Qemu-block] [PATCH v3 01/15] block: Rename blk_write_zeroes(),
Max Reitz <=
- [Qemu-block] [PATCH v3 04/15] block: Default to enabled write cache in blk_new(), Kevin Wolf, 2016/05/25
- [Qemu-block] [PATCH v3 05/15] block: Convert block job core to BlockBackend, Kevin Wolf, 2016/05/25
- [Qemu-block] [PATCH v3 07/15] stream: Use BlockBackend for I/O, Kevin Wolf, 2016/05/25
- [Qemu-block] [PATCH v3 06/15] block: Make blk_co_preadv/pwritev() public, Kevin Wolf, 2016/05/25
- [Qemu-block] [PATCH v3 10/15] backup: Don't leak BackupBlockJob in error path, Kevin Wolf, 2016/05/25