[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from "git
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-block] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default |
Date: |
Wed, 1 Jun 2016 11:13:35 +0100 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Wed, Jun 01, 2016 at 05:44:21PM +0800, Fam Zheng wrote:
> Currently, if not specified in "./configure", QEMU_PKGVERSION will be
> empty. Write a rule in Makefile to generate a value from "git describe"
> combined with a possible git tree cleanness suffix, and write into a new
> header.
>
> $ cat qemu-version.h
> #define QEMU_PKGVERSION "-v2.6.0-557-gd6550e9-dirty"
>
> Include the header in .c files where the macro is referenced. It's not
> necessary to include it in all files, otherwise each time the content of
> the file changes, all sources have to be recompiled.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> Makefile | 22 +++++++++++++++++++++-
> linux-user/main.c | 1 +
> qemu-img.c | 1 +
> qmp.c | 1 +
> scripts/create_config | 4 ----
> vl.c | 1 +
> 6 files changed, 25 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
[Qemu-block] [PATCH v3 1/2] Makefile: Add a "FORCE" target, Fam Zheng, 2016/06/01
Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/2] Let PKGVERSION include the "git describe" output, Changlong Xie, 2016/06/20