[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: Drop bdrv_ioctl_bh_cb
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH] block: Drop bdrv_ioctl_bh_cb |
|
Date: |
Wed, 1 Jun 2016 12:48:33 -0700 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jun 01, 2016 at 09:52:23AM +0800, Fam Zheng wrote:
> Similar to the "!drv || !drv->bdrv_aio_ioctl" case above, here it is
> okay to set co.ret and return. As pointed out by Paolo, a BH will be
> created as necessary by the caller (bdrv_co_maybe_schedule_bh).
> Besides, as pointed out by Kevin, "data" was leaked before.
>
> Reported-by: Kevin Wolf <address@hidden>
> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/io.c | 20 ++------------------
> 1 file changed, 2 insertions(+), 18 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature