Re: [Qemu-block] [Qemu-devel] [PATCH v5 20/27] qemu-iotests: 046: Move version detection out from verify_io

[Fam Zheng]

On Wed, 05/25 15:23, Max Reitz wrote:
> > -verify_io | $QEMU_IO "$TEST_IMG" | _filter_qemu_io
> > +if ($QEMU_IMG info -f "$IMGFMT" "$TEST_IMG" | grep "compat: 0.10" > 
> > /dev/null); then
> > +    # For v2 images, discarded clusters are read from the backing file
> > +    # Keep the variable empty so that the backing file value can be used as
> > +    # the default below
> > +    discarded=
> > +else
> > +    # Discarded clusters are zeroed for v3 or later
> > +    discarded=0
> > +fi
> > +
> > +verify_io $discarded | $QEMU_IO -L "$TEST_IMG" | _filter_qemu_io
> 
> With the code movement, the -L becomes unnecessary here.

Good point, removing it.

Fam