qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] iotests: 095: Clean up QEMU before showing imag


From: Max Reitz
Subject: Re: [Qemu-block] [PATCH] iotests: 095: Clean up QEMU before showing image info
Date: Fri, 3 Jun 2016 16:52:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 03.06.2016 11:07, Fam Zheng wrote:
> Somehow in my locking series, I missed this case where concurrent access
> to an image is performed, perhaps we can remove this case independently.

The patch itself is good, but this commit message will not make much
sense in the git log. I'd be fine with removing it completely because
the title itself should be sufficient. (Which is something I can do in
case you agree.)

Max

> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  tests/qemu-iotests/095 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qemu-iotests/095 b/tests/qemu-iotests/095
> index dad04b9..030adb2 100755
> --- a/tests/qemu-iotests/095
> +++ b/tests/qemu-iotests/095
> @@ -74,6 +74,8 @@ _send_qemu_cmd $h "{ 'execute': 'block-commit',
>                                   'arguments': { 'device': 'test',
>                                   'top': '"${TEST_IMG}.snp1"' } }" 
> "BLOCK_JOB_COMPLETED"
>  
> +_cleanup_qemu
> +
>  echo
>  echo "=== Base image info after commit and resize ==="
>  TEST_IMG="${TEST_IMG}.base" _img_info | _filter_img_info
> 


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]