|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-block] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads |
| Date: | Thu, 9 Jun 2016 10:25:24 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 09/06/2016 09:35, Stefan Hajnoczi wrote:
>
> if (s->dataplane) {
> virtio_blk_data_plane_stop(s->dataplane);
> }
>
> virtio_save(vdev, f);
> }
>
> We reach the situation I described where BDS AioContext changes but
> mirror_run() is still in the IOThread AioContext.
Why is the virtio_blk_data_plane_stop necessary? It used to sync
between vring and virtio state, but that's not required anymore---and we
know that the virtqueues are quiescent at this point...
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |