Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/3] coccinelle: Clean up error checks and return value variables

[Markus Armbruster]

Eduardo Habkost <address@hidden> writes:

> Changes v1 -> v2:
> * The Coccinelle scripts were simplified by using "when"
>   constraints to detect when a variable is not used elsewhere
>   inside the function.
> * Added script to remove unnecessary variables for function
>   return value.
> * Coccinelle scripts added to scripts/coccinelle.
>
> Changes v2 -> v3 on patch 2/3:
> * Remove unused metavariable from script
>  * Do changes only if errp is not touched before the error_setg()
>    call (so we are sure *errp is not set and error_setg() won't
>    abort)
>  * Changes dropped from v2:
>    * block.c:bdrv_create_co_entry()
>    * block.c:bdrv_create_file()
>    * blockdev.c:qmp_blockdev_mirror()
>
> Changes v2 -> v3 on patch 3/3:
> * Not a RFC anymore
> * Used --keep-comments option
> * Instead of using:
>     - VAR = E;
>     + return E;
>   use:
>     - VAR =
>     + return
>       E
>   This makes Coccinelle keep the existing formatting on some
>   cases.

Neat trick.

> * Manual fixups

With the commit message of 3/3 amended, series
Reviewed-by: Markus Armbruster <address@hidden>

My other suggested touch ups are optional.  If you don't object, I'll do
them, and take the result through my error-next branch.