Re: [Qemu-block] [PATCH 6/6] block: Don't enforce 512 byte minimum alignment

[Kevin Wolf]

Am 14.06.2016 um 14:09 hat Stefan Hajnoczi geschrieben:
> On Wed, Jun 08, 2016 at 04:10:11PM +0200, Kevin Wolf wrote:
> > diff --git a/block.c b/block.c
> > index f54bc25..3d850a2 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -937,7 +937,7 @@ static int bdrv_open_common(BlockDriverState *bs, 
> > BdrvChild *file,
> >          goto fail_opts;
> >      }
> >  
> > -    bs->request_alignment = 512;
> > +    bs->request_alignment = drv->bdrv_co_preadv ? 1 : 512;
> 
> What happens in the raw-posix.c AIO case?  There we should still use
> 512.

I'm only changing the default value here. raw-posix already overrides
bs->request_alignment as needed, see raw_probe_alignment().

Kevin

pgpLNYJTaBJsh.pgp
Description: PGP signature