[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 02/11] qapi: allow QmpInputVisitor to auto-ca
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-block] [PATCH v5 02/11] qapi: allow QmpInputVisitor to auto-cast types |
Date: |
Tue, 14 Jun 2016 15:10:26 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jun 08, 2016 at 02:01:23PM +0200, Paolo Bonzini wrote:
>
>
> On 02/06/2016 18:46, Daniel P. Berrange wrote:
> > Currently the QmpInputVisitor assumes that all scalar
> > values are directly represented as their final types.
> > ie it assumes an 'int' is using QInt, and a 'bool' is
> > using QBool.
> >
> > This extends it so that QString is optionally permitted
> > for any of the non-string scalar types. This behaviour
> > is turned on by requesting the 'autocast' flag in the
> > constructor.
> >
> > This makes it possible to use QmpInputVisitor with a
> > QDict produced from QemuOpts, where everything is in
> > string format.
>
> Perhaps this should instead be a separate QmpStringInputVisitor visitor
> that _only_ accepts strings? You can reuse most of the QmpInputVisitor
> by putting it in the same file, because the struct and list visitors are
> compatible.
Yes, that actually works out quite nicely indeed, and in fact
showed up a bug in my unit tests too :-)
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 01/11] qdict: implement a qdict_crumple method for un-flattening a dict, (continued)
[Qemu-block] [PATCH v5 04/11] util: add QAuthZ object as an authorization base class, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 03/11] qom: support arbitrary non-scalar properties with -object, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 02/11] qapi: allow QmpInputVisitor to auto-cast types, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 05/11] util: add QAuthZSimple object type for a simple access control list, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 06/11] acl: delete existing ACL implementation, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 07/11] qemu-nbd: add support for ACLs for TLS clients, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 09/11] migration: add support for a "tls-acl" migration parameter, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 08/11] nbd: allow an ACL to be set with nbd-server-start QMP command, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 10/11] chardev: add support for ACLs for TLS clients, Daniel P. Berrange, 2016/06/02
[Qemu-block] [PATCH v5 11/11] vnc: allow specifying a custom ACL object name, Daniel P. Berrange, 2016/06/02