[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 12/13] MC146818 RTC: add GPIO access to output I
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 12/13] MC146818 RTC: add GPIO access to output IRQ |
Date: |
Fri, 17 Jun 2016 16:08:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17/06/2016 15:11, Efimov Vasily wrote:
> qdev_init_nofail(dev);
> if (intercept_irq) {
> - s->irq = intercept_irq;
> + qdev_connect_gpio_out(dev, 0, intercept_irq);
> } else {
> isa_init_irq(isadev, &s->irq, RTC_ISA_IRQ);
> }
Please introduce a wrapper isa_connect_gpio_out so that you can do
if (intercept_irq) {
qdev_connect_gpio_out(dev, 0, intercept_irq);
} else {
isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ);
}
Thanks,
Paolo
- [Qemu-block] [PATCH 00/13] Make Q35 devices closer to Qemu object model., Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 03/13] vmport: identify vmport type by macro TYPE_VMPORT, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 04/13] pflash: make TYPE_CFI_PFLASH0{1, 2} macros public, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 12/13] MC146818 RTC: add GPIO access to output IRQ, Efimov Vasily, 2016/06/17
- Re: [Qemu-block] [PATCH 12/13] MC146818 RTC: add GPIO access to output IRQ,
Paolo Bonzini <=
- [Qemu-block] [PATCH 01/13] ide: move headers to include folder, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 09/13] ICH9 SMB: make TYPE_ICH9_SMB_DEVICE macro public, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 10/13] ICH9 LPC: handle PIC and I/O APIC IRQs as qdev GPIO, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 05/13] Q35: implement property interfece to several parameters, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 08/13] port92: handle A20 IRQ as GPIO, Efimov Vasily, 2016/06/17