[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 04/15] block: Simplify find_block_job() and make
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH 04/15] block: Simplify find_block_job() and make it accept a job ID |
|
Date: |
Tue, 21 Jun 2016 14:27:49 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 20 Jun 2016 08:53:08 PM CEST, Eric Blake wrote:
>> +static BlockJob *find_block_job(const char *id, const char *device,
>> + AioContext **aio_context, Error **errp)
>
> Can this signature just be const char *id_or_device, rather than two
> parameters,...
But what if there's a name clash?
Berto
- [Qemu-block] [PATCH 05/15] blockjob: Add 'job_id' parameter to block_job_create(), (continued)
[Qemu-block] [PATCH 12/15] blockjob: Add 'id' parameter to 'block-job-pause', Alberto Garcia, 2016/06/09