[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to tr
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes |
Date: |
Wed, 22 Jun 2016 17:22:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 03.06.2016 06:32, Fam Zheng wrote:
> Upon each bit toggle, the corresponding bit in the meta bitmap will be
> set.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> ---
> block/dirty-bitmap.c | 2 +-
> include/qemu/hbitmap.h | 17 +++++++++++++
> util/hbitmap.c | 69
> +++++++++++++++++++++++++++++++++++++++-----------
> 3 files changed, 72 insertions(+), 16 deletions(-)
>
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index ec073ee..628b77c 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -231,7 +231,7 @@ static void
> bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
> BdrvDirtyBitmap *bm, *next;
> QLIST_FOREACH_SAFE(bm, &bs->dirty_bitmaps, list, next) {
> if ((!bitmap || bm == bitmap) && (!only_named || bm->name)) {
> - assert(!bitmap->active_iterators);
> + assert(!bm->active_iterators);
Same comment as for v4, this should be squashed into the previous patch.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 00/10] Dirty bitmap changes for migration/persistence work, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 03/10] tests: Add test code for meta bitmap, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 01/10] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 06/10] block: Assert that bdrv_release_dirty_bitmap succeeded, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 04/10] block: Support meta dirty bitmap, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/06/03
- Re: [Qemu-block] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes,
Max Reitz <=
- [Qemu-block] [PATCH v5 05/10] block: Add two dirty bitmap getters, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 07/10] hbitmap: serialization, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 08/10] block: BdrvDirtyBitmap serialization interface, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 10/10] block: More operations for meta dirty bitmap, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 09/10] tests: Add test code for hbitmap serialization, Fam Zheng, 2016/06/03
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/10] Dirty bitmap changes for migration/persistence work, Fam Zheng, 2016/06/03