[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/4] virtio: Always use aio path to set host han
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH 2/4] virtio: Always use aio path to set host handler |
|
Date: |
Fri, 24 Jun 2016 08:39:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 24/06/2016 07:12, Fam Zheng wrote:
> Apart from the interface difference, the aio version works the same as
> the non-aio one. The event notifier versus aio fd handler makes no
> diffeerence, except the former led to an ugly patch in commit
> ab27c3b5e7, which won't be necessary any more.
>
> As the first step to unify them, all callers are switched to this
> renamed aio iterface, and function comment is added.
I think this is too aggressive, and I'm not sure it's correct.
bdrv_drain wants to look at block devices only, while this would also
process NICs too for example. I don't know the effect.
Can we do this only for virtio-blk and virtio-scsi?
Paolo