[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 20/22] block: Move request_alignment into Blo
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 20/22] block: Move request_alignment into BlockLimit |
Date: |
Fri, 24 Jun 2016 08:17:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/24/2016 07:45 AM, Kevin Wolf wrote:
> Am 24.06.2016 um 00:37 hat Eric Blake geschrieben:
>> It makes more sense to have ALL block size limit constraints
>> in the same struct. Improve the documentation while at it.
>>
>> Simplify a couple of conditionals, now that we have audited and
>> documented that request_alignment is always non-zero.
>
> Now you mention in the commit message that request_alignment is always
> non-zero and this is supposedly documented...
>
>> Signed-off-by: Eric Blake <address@hidden>
>>
>
>> @@ -324,6 +324,12 @@ struct BlockDriver {
>> };
>>
>> typedef struct BlockLimits {
>> + /* Alignment requirement, in bytes, for offset/length of I/O
>> + * requests. Must be a power of 2 less than INT_MAX. A value of 0
>> + * defaults to 1 for drivers with modern byte interfaces, and to
>> + * 512 otherwise. */
>> + uint32_t request_alignment;
>
> ...but you didn't actually change the documentation.
Oops. Blame late night patch editing :)
>
> This is the only problem I saw in this series, so if you post a new
> version of the comment, I can change it while applying the series.
/* Alignment requirement, in bytes, for offset/length of I/O
* requests. Must be a power of 2 less than INT_MAX; defaults to
* 1 for drivers with modern byte interfaces, and to 512
* otherwise. */
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v3 21/22] block: Fix error message style, (continued)
- [Qemu-block] [PATCH v3 13/22] block: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 16/22] block: Wording tweaks to write zeroes limits, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 20/22] block: Move request_alignment into BlockLimit, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 17/22] block: Switch discard length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 19/22] block: Split bdrv_merge_limits() from bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 22/22] block: Use bool as appropriate for BDS members, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 18/22] block: Drop raw_refresh_limits(), Eric Blake, 2016/06/23