[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 10/17] block: Use BlockBackend for I/O in bdrv_c
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 10/17] block: Use BlockBackend for I/O in bdrv_commit() |
Date: |
Sat, 25 Jun 2016 17:34:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 21.06.2016 11:21, Kevin Wolf wrote:
> Just like block jobs, the HMP commit command should use its own
> BlockBackend for doing I/O on BlockDriverStates.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/commit.c | 30 ++++++++++++++++++++----------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/block/commit.c b/block/commit.c
> index 4ac3df3..17f365f 100644
> --- a/block/commit.c
> +++ b/block/commit.c
[...]
> @@ -342,7 +349,7 @@ int bdrv_commit(BlockDriverState *bs)
>
> /* qemu_try_blockalign() for bs will choose an alignment that works for
> * bs->backing->bs as well, so no need to compare the alignment
> manually. */
This comment will need a little change, too.
With that done: Reviewed-by: Max Reitz <address@hidden>
> - buf = qemu_try_blockalign(bs, COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
> + buf = blk_try_blockalign(src, COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
> if (buf == NULL) {
> ret = -ENOMEM;
> goto ro_cleanup;
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH 05/17] block: Convert bdrv_co_writev() to BdrvChild, (continued)
- [Qemu-block] [PATCH 10/17] block: Use BlockBackend for I/O in bdrv_commit(), Kevin Wolf, 2016/06/21
- Re: [Qemu-block] [PATCH 10/17] block: Use BlockBackend for I/O in bdrv_commit(),
Max Reitz <=
- [Qemu-block] [PATCH 09/17] block: Move bdrv_commit() to block/commit.c, Kevin Wolf, 2016/06/21
- [Qemu-block] [PATCH 06/17] block: Convert bdrv_aio_readv() to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-block] [PATCH 13/17] block: Convert bdrv_pread(v) to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-block] [PATCH 11/17] block: Convert bdrv_read() to BdrvChild, Kevin Wolf, 2016/06/21
- [Qemu-block] [PATCH 14/17] block: Convert bdrv_pwrite(v/_sync) to BdrvChild, Kevin Wolf, 2016/06/21