Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] blockdev: Add dynamic module loading for block drivers

[Stefan Hajnoczi]

On Fri, Jun 24, 2016 at 11:37:56AM +0100, Daniel P. Berrange wrote:
> On Fri, Jun 24, 2016 at 11:04:43AM +0100, Stefan Hajnoczi wrote:
> > On Wed, Jun 22, 2016 at 05:35:54PM -0400, Colin Lord wrote:
> > 
> > >  
> > > @@ -447,8 +466,15 @@ int get_tmp_filename(char *filename, int size)
> > >  static BlockDriver *find_hdev_driver(const char *filename)
> > >  {
> > >      int score_max = 0, score;
> > > +    size_t i;
> > >      BlockDriver *drv = NULL, *d;
> > >  
> > > +    for (i = 0; i < ARRAY_SIZE(block_driver_modules); ++i) {
> > > +        if (block_driver_modules[i].has_probe_device) {
> > > +            block_module_load_one(block_driver_modules[i].library_name);
> > > +        }
> > > +    }
> > 
> > This patch series needs to solve probing so that we don't end up loading
> > all block drivers.  Fam's suggestion for a built-in probe.c sounds good
> > to me.
> 
> Do we really care if probing loads all drivers ? Last time we discussed
> this I thought we decided that because probing almost always leads to
> security vulnerabilities, no one should use it by default and so we
> don't really need to worry about optimizing it.

If the code to handle probing is simple then doing it is nice.

Stefan

signature.asc
Description: PGP signature