qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV


From: Jeff Cody
Subject: Re: [Qemu-block] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV
Date: Tue, 28 Jun 2016 22:53:45 -0400
User-agent: Mutt/1.5.24 (2015-08-30)

On Wed, Jun 22, 2016 at 03:51:01PM -0400, John Snow wrote:
> e5b43573 caused a regression in the preparation of our IO vectors, such
> that if a small granularity but a large buffer size is chosen, we may
> accidentally exceed MAX_IOV and the request will fail.
> 
> This has been fixed before in cae98cb8, and now we'll fix it again.
> To keep it fixed, we'll add an iotest this time.
> 
> [Thanks to Max for finding the root cause.]
> 
> John Snow (3):
>   mirror: clarify mirror_do_read return code
>   mirror: limit niov to IOV_MAX elements, again
>   iotests: add small-granularity mirror test
> 
>  block/mirror.c             | 10 ++++++++--
>  tests/qemu-iotests/041     | 30 ++++++++++++++++++++++++++++++
>  tests/qemu-iotests/041.out |  4 ++--
>  3 files changed, 40 insertions(+), 4 deletions(-)
> 
> -- 
> 2.4.11
> 

Thanks,

Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc.git block

-Jeff



reply via email to

[Prev in Thread] Current Thread [Next in Thread]