[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 09/10] blockjob: assert(cb) when create job
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PULL 09/10] blockjob: assert(cb) when create job |
Date: |
Tue, 28 Jun 2016 23:10:43 -0400 |
From: Changlong Xie <address@hidden>
Callback for block job should always exist
Suggested-by: Paolo Bonzini <address@hidden>
Suggested-by: Kevin Wolf <address@hidden>
Signed-off-by: Changlong Xie <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>
---
block/backup.c | 1 -
blockjob.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index 581269b..f87f8d5 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -489,7 +489,6 @@ void backup_start(BlockDriverState *bs, BlockDriverState
*target,
assert(bs);
assert(target);
- assert(cb);
if (bs == target) {
error_setg(errp, "Source and target cannot be the same");
diff --git a/blockjob.c b/blockjob.c
index 90c4e26..205da9d 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -110,6 +110,7 @@ void *block_job_create(const BlockJobDriver *driver,
BlockDriverState *bs,
BlockBackend *blk;
BlockJob *job;
+ assert(cb);
if (bs->job) {
error_setg(errp, QERR_DEVICE_IN_USE, bdrv_get_device_name(bs));
return NULL;
--
1.9.3
- [Qemu-block] [PULL 00/10] Block patches, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 01/10] block/gluster: add support for SEEK_DATA/SEEK_HOLE, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 02/10] block/nfs: refuse readahead if cache.direct is on, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 03/10] block/nfs: add support for libnfs pagecache, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 04/10] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration(), Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 05/10] block/gluster: add support for selecting debug logging level, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 06/10] mirror: clarify mirror_do_read return code, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 07/10] mirror: limit niov to IOV_MAX elements, again, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 08/10] iotests: add small-granularity mirror test, Jeff Cody, 2016/06/28
- [Qemu-block] [PULL 09/10] blockjob: assert(cb) when create job,
Jeff Cody <=
- [Qemu-block] [PULL 10/10] mirror: fix misleading comments, Jeff Cody, 2016/06/28
- Re: [Qemu-block] [PULL 00/10] Block patches, Peter Maydell, 2016/06/29