[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/3] ide: ignore retry_unit check for non-retry
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations |
|
Date: |
Wed, 29 Jun 2016 12:41:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 29/06/2016 10:35, Evgeny Yakovlev wrote:
>>>
>> Wouldn't the assertion fail for a PIO read/write too? Perhaps
>> retry_unit should be set to s->unit in ide_transfer_start too.
>
> If PIO follows DMA and fails then yes, it looks like it will trigger an
> assert. I am not sure about setting retry_unit in ide_transfer_start. It
> looks like currently only DMA I/O entries touch retry_unit at all. Does
> that mean that PIO, flush, etc do not support retries by design and we
> need to add more exceptions to assert check or is it a real bug in how
> retries are initialized?
Both PIO and flush do support retries, so I think it is a real bug.
Paolo
Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] block: ignore flush requests when storage is clean, Eric Blake, 2016/06/24