[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 05/11] blockjob: Add 'job_id' parameter to bl
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 05/11] blockjob: Add 'job_id' parameter to block_job_create() |
Date: |
Sat, 2 Jul 2016 16:09:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 01.07.2016 17:52, Alberto Garcia wrote:
> When a new job is created, the job ID is taken from the device name of
> the BDS. This patch adds a new 'job_id' parameter to let the caller
> provide one instead.
>
> This patch also verifies that the ID is always unique and well-formed.
> This causes problems in a couple of places where no ID is being set,
> because the BDS does not have a device name.
>
> In the case of test_block_job_start() (from test-blockjob-txn.c) we
> can simply use this new 'job_id' parameter to set the missing ID.
>
> In the case of img_commit() (from qemu-img.c) we still don't have the
> API to make commit_active_start() set the job ID, so we solve it by
> setting a default value. We'll get rid of this as soon as we extend
> the API.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block/backup.c | 3 ++-
> block/commit.c | 2 +-
> block/mirror.c | 2 +-
> block/stream.c | 2 +-
> blockjob.c | 29 +++++++++++++++++++++++++----
> include/block/blockjob.h | 8 +++++---
> tests/test-blockjob-txn.c | 7 +++++--
> 7 files changed, 40 insertions(+), 13 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 00/11] Allow creating block jobs with a user-defined ID, Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 10/11] qemu-img: Set the ID of the block job in img_commit(), Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 02/11] blockjob: Update description of the 'id' field, Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 01/11] stream: Fix prototype of stream_start(), Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 05/11] blockjob: Add 'job_id' parameter to block_job_create(), Alberto Garcia, 2016/07/01
- Re: [Qemu-block] [PATCH v3 05/11] blockjob: Add 'job_id' parameter to block_job_create(),
Max Reitz <=
- [Qemu-block] [PATCH v3 09/11] commit: Add 'job-id' parameter to 'block-commit', Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 04/11] block: Use block_job_get() in find_block_job(), Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 11/11] blockjob: Update description of the 'device' field in the QMP API, Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 03/11] blockjob: Add block_job_get(), Alberto Garcia, 2016/07/01
- [Qemu-block] [PATCH v3 08/11] stream: Add 'job-id' parameter to 'block-stream', Alberto Garcia, 2016/07/01