Re: [Qemu-block] [PATCH v2 4/6] block/qdev: Allow configuring rerror/werror with qdev properties

[Max Reitz]

On 30.06.2016 16:13, Kevin Wolf wrote:
> The rerror/werror policies are implemented in the devices, so that's
> where they should be configured. In comparison to the old options in
> -drive, the qdev properties are only added to those devices that
> actually support them.
> 
> If the option isn't given (or "auto" is specified), the setting of the
> BlockBackend is used for compatibility with the old options. For block
> jobs, "auto" is the same as "enospc".
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/block-backend.c        |  1 +
>  blockjob.c                   |  1 +
>  hw/block/block.c             | 12 ++++++++++++
>  hw/block/virtio-blk.c        |  1 +
>  hw/core/qdev-properties.c    | 13 +++++++++++++
>  hw/ide/qdev.c                |  1 +
>  hw/scsi/scsi-disk.c          |  1 +
>  include/hw/block/block.h     |  8 ++++++++
>  include/hw/qdev-properties.h |  4 ++++
>  qapi/block-core.json         |  4 +++-
>  10 files changed, 45 insertions(+), 1 deletion(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature