[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v4 10/11] qemu-img: Set the ID of the block job in i
From: |
Alberto Garcia |
Subject: |
[Qemu-block] [PATCH v4 10/11] qemu-img: Set the ID of the block job in img_commit() |
Date: |
Tue, 5 Jul 2016 17:29:01 +0300 |
img_commit() creates a block job without an ID. This is no longer
allowed now that we require it to be unique and well-formed. We were
solving this by having a fallback in block_job_create(), but now that
we extended the API of commit_active_start() we can finally set an
explicit ID and revert that change.
Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
blockjob.c | 6 ------
qemu-img.c | 2 +-
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index 511c0db..3b9cec7 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -132,12 +132,6 @@ void *block_job_create(const char *job_id, const
BlockJobDriver *driver,
if (job_id == NULL) {
job_id = bdrv_get_device_name(bs);
- /* Assign a default ID if the BDS does not have a device
- * name. We'll get rid of this soon when we finish extending
- * the API of all commands that create block jobs. */
- if (job_id[0] == '\0') {
- job_id = "default_job";
- }
}
if (!id_wellformed(job_id)) {
diff --git a/qemu-img.c b/qemu-img.c
index a78f598..521724c 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -921,7 +921,7 @@ static int img_commit(int argc, char **argv)
.bs = bs,
};
- commit_active_start(NULL, bs, base_bs, 0, BLOCKDEV_ON_ERROR_REPORT,
+ commit_active_start("commit", bs, base_bs, 0, BLOCKDEV_ON_ERROR_REPORT,
common_block_job_cb, &cbi, &local_err);
if (local_err) {
goto done;
--
2.8.1
- [Qemu-block] [PATCH v4 00/11] Allow creating block jobs with a user-defined ID, Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 05/11] blockjob: Add 'job_id' parameter to block_job_create(), Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 08/11] stream: Add 'job-id' parameter to 'block-stream', Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 11/11] blockjob: Update description of the 'device' field in the QMP API, Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 04/11] block: Use block_job_get() in find_block_job(), Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 07/11] backup: Add 'job-id' parameter to 'blockdev-backup' and 'drive-backup', Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 10/11] qemu-img: Set the ID of the block job in img_commit(),
Alberto Garcia <=
- [Qemu-block] [PATCH v4 03/11] blockjob: Add block_job_get(), Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 01/11] stream: Fix prototype of stream_start(), Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 06/11] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror', Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 02/11] blockjob: Update description of the 'id' field, Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 09/11] commit: Add 'job-id' parameter to 'block-commit', Alberto Garcia, 2016/07/05
- Re: [Qemu-block] [PATCH v4 00/11] Allow creating block jobs with a user-defined ID, Kevin Wolf, 2016/07/07