Re: [Qemu-block] [PATCH v3 03/32] blockdev: Add dynamic module loading for block drivers

[Max Reitz]

On 05.07.2016 17:24, Colin Lord wrote:
> From: Marc Mari <address@hidden>
> 
> Extend the current module interface to allow for block drivers to be loaded
> dynamically on request.
> 
> The only block drivers that can be converted into modules are the drivers
> that don't perform any init operation except for registering themselves.
> 
> All the necessary module information is located in a new structure found in
> module_block.h
> 
> Signed-off-by: Marc Marí <address@hidden>
> Signed-off-by: Colin Lord <address@hidden>
> ---
>  block.c               | 110 
> ++++++++++++++++++++++++++++++++++++++++++--------
>  include/qemu/module.h |   3 ++
>  util/module.c         |  38 +++++------------
>  3 files changed, 108 insertions(+), 43 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

> diff --git a/block.c b/block.c
> index f4648e9..88a05b2 100644
> --- a/block.c
> +++ b/block.c

[...]

> +    for (n = 0; n < ARRAY_SIZE(block_driver_modules); n++) {

(yay for post-increment)

signature.asc
Description: OpenPGP digital signature