[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 2/7] mirror: make sectors_in_flight int64_t
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v2 2/7] mirror: make sectors_in_flight int64_t |
|
Date: |
Thu, 7 Jul 2016 15:58:13 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/07/2016 03:35 AM, Denis V. Lunev wrote:
> We keep here the sum of int fields. Thus this could easily overflow,
> especially when we will start sending big requests in next patches.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Eric Blake <address@hidden>
> ---
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 8d96049..9850e54 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -60,7 +60,7 @@ typedef struct MirrorBlockJob {
>
> unsigned long *in_flight_bitmap;
> int in_flight;
> - int sectors_in_flight;
> + int64_t sectors_in_flight;
> int ret;
> bool unmap;
> bool waiting_for_io;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature