[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] vmdk: fix metadata write regression
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2] vmdk: fix metadata write regression |
Date: |
Fri, 8 Jul 2016 15:26:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 07.07.2016 10:42, Reda Sallahi wrote:
> Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on
> writes. It writes metadata after every write instead of doing it only once
> for each cluster.
>
> vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch
> sets m_data as valid only when we have a new cluster which hasn't been
> allocated before or a zero grain.
>
> Signed-off-by: Reda Sallahi <address@hidden>
> ---
> v2: Corrected the commit id referenced in the commit message.
>
> block/vmdk.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Thanks Reda, I've applied the patch to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature