Re: [Qemu-block] [PATCH v2 0/7] drive-mirror improvements

[Fam Zheng]

On Thu, 07/07 12:35, Denis V. Lunev wrote:
> This patchset contains patches dealing with known-to-be-zero areas in drive
> mirror from [PATCH 0/9] major rework of drive-mirror patchset.

Looks pretty good overall despite the minor comments.

Reviewed-by: Fam Zheng <address@hidden>

> 
> Changes from v1:
> - only patches dealing with zeroes remains
> - ported to current HEAD
> - fixed issue with dirty-bitmap, int length is changed with int64
> - fixed sectors_in_flight usage
> - patch 6 is reworked taken into account bugs found in active mirror
> - fixed patch 7
> - direct checking of .bdrv_co_write_zeroes is replaced with
>   bdrv_can_write_zeroes_with_unmap
> - added fixes for bdrv_can_write_zeroes_with_unmap
> 
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Eric Blake <address@hidden>
> 
> Denis V. Lunev (7):
>   dirty-bitmap: operate with int64_t amount
>   mirror: make sectors_in_flight int64_t
>   mirror: create mirror_dirty_init helper for mirror_run
>   block: remove extra condition in bdrv_can_write_zeroes_with_unmap
>   mirror: optimize dirty bitmap filling in mirror_run a bit
>   mirror: efficiently zero out target
>   mirror: improve performance of mirroring of empty disk
> 
>  block.c                      |   2 +-
>  block/dirty-bitmap.c         |   6 +-
>  block/mirror.c               | 138 
> ++++++++++++++++++++++++++++++-------------
>  include/block/block_int.h    |   2 +-
>  include/block/dirty-bitmap.h |   4 +-
>  5 files changed, 103 insertions(+), 49 deletions(-)
> 
> -- 
> 2.5.0
>