[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v5 12/15] drive-backup: added suppo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v5 12/15] drive-backup: added support for data compression |
Date: |
Thu, 14 Jul 2016 13:17:24 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, Jul 04, 2016 at 03:28:23PM +0300, Denis V. Lunev wrote:
> From: Pavel Butsykin <address@hidden>
>
> The idea is simple - backup is "written-once" data. It is written block
> by block and it is large enough. It would be nice to save storage
> space and compress it.
>
> The patch adds a flag to the qmp/hmp drive-backup command which enables
> block compression. Compression should be implemented in the format driver
> to enable this feature.
>
> There are some limitations of the format driver to allow compressed writes.
> We can write data only once. Though for backup this is perfectly fine.
> These limitations are maintained by the driver and the error will be
> reported if we are doing something wrong.
>
> Signed-off-by: Pavel Butsykin <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: John Snow <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> block/backup.c | 12 +++++++++++-
> blockdev.c | 9 ++++++---
> hmp-commands.hx | 8 +++++---
> hmp.c | 3 +++
> include/block/block_int.h | 1 +
> qapi/block-core.json | 5 ++++-
> qmp-commands.hx | 5 ++++-
> 7 files changed, 34 insertions(+), 9 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v5 08/15] block: remove BlockDriver.bdrv_write_compressed, (continued)
- [Qemu-block] [PATCH v5 08/15] block: remove BlockDriver.bdrv_write_compressed, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 10/15] block: simplify drive-backup, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 11/15] block: simplify blockdev-backup, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 13/15] blockdev-backup: added support for data compression, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 12/15] drive-backup: added support for data compression, Denis V. Lunev, 2016/07/04
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 12/15] drive-backup: added support for data compression,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH v5 14/15] qemu-iotests: test backup compression in 055, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 15/15] qemu-iotests: add vmdk for test backup compression in 055, Denis V. Lunev, 2016/07/04
- Re: [Qemu-block] [PATCH v5 00/15] backup compression, Denis V. Lunev, 2016/07/08
- Re: [Qemu-block] [PATCH v5 00/15] backup compression, Jeff Cody, 2016/07/19