Re: [Qemu-block] [Qemu-devel] [PATCH v5 06/14] nbd: Send message along with server NBD_REP_ERR errors

[Fam Zheng]

On Mon, 07/18 22:07, Eric Blake wrote:
>  nbd/server.c | 78 
> +++++++++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 59 insertions(+), 19 deletions(-)
> 
> diff --git a/nbd/server.c b/nbd/server.c
> index c8716f1..ad31c4a 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -235,6 +235,38 @@ static int nbd_negotiate_send_rep(QIOChannel *ioc, 
> uint32_t type, uint32_t opt)
>      return nbd_negotiate_send_rep_len(ioc, type, opt, 0);
>  }
> 
> +/* Send an error reply.
> + * Return -errno to kill connection, 0 to continue negotiation. */
> +static int GCC_FMT_ATTR(4, 5)
> +    nbd_negotiate_send_rep_err(QIOChannel *ioc, uint32_t type,

Isn't the function name supposed to be place at col 0?

> +                               uint32_t opt, const char *fmt, ...)