[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4] qemu-img: add the 'dd' subcommand
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v4] qemu-img: add the 'dd' subcommand |
Date: |
Wed, 20 Jul 2016 10:10:23 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jul 19, 2016 at 07:44:11PM +0200, Reda Sallahi wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>
> For the start, this implements the bs, if, of and count options and requires
> both if and of to be specified (no stdin/stdout if not specified) and doesn't
> support tty, pipes, etc.
>
> The image format must be specified with -O for the output if the raw format
> is not the intended one.
>
> Two tests are added to test qemu-img dd.
>
> Signed-off-by: Reda Sallahi <address@hidden>
> ---
> Changes from v3:
> * Delete an unused (so far) field in DdIo.
>
> Changes from v2:
> * Add copyright headers to new files.
>
> Changes from v1:
> * Removal of dead code.
> * Fix a memory leak.
> * Complete the cleanup function in the test cases.
>
> qemu-img-cmds.hx | 6 +
> qemu-img.c | 361
> ++++++++++++++++++++++++++++++++++++++-
> tests/qemu-iotests/158 | 68 ++++++++
> tests/qemu-iotests/158.out | 15 ++
> tests/qemu-iotests/159 | 70 ++++++++
> tests/qemu-iotests/159.out | 87 ++++++++++
> tests/qemu-iotests/common.filter | 9 +
> tests/qemu-iotests/group | 2 +
> 8 files changed, 617 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/158
> create mode 100644 tests/qemu-iotests/158.out
> create mode 100755 tests/qemu-iotests/159
> create mode 100644 tests/qemu-iotests/159.out
Please document the new command in qemu-img.texi.
Stefan
signature.asc
Description: PGP signature