[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing b
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint |
Date: |
Mon, 25 Jul 2016 23:18:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 22.07.2016 12:15, Wang WeiWei wrote:
> From: Wen Congyang <address@hidden>
>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> Signed-off-by: Wang WeiWei <address@hidden>
> ---
> block/backup.c | 18 ++++++++++++++++++
> include/block/block_backup.h | 3 +++
> 2 files changed, 21 insertions(+)
> create mode 100644 include/block/block_backup.h
[...]
> diff --git a/include/block/block_backup.h b/include/block/block_backup.h
> new file mode 100644
> index 0000000..3753bcb
> --- /dev/null
> +++ b/include/block/block_backup.h
> @@ -0,0 +1,3 @@
> +#include "block/block_int.h"
> +
> +void backup_do_checkpoint(BlockJob *job, Error **errp);
Include guards and copyright notice missing. I don't mind the missing
copyright notice because it will default to GPL anyway. Also, I
personally don't really mind the missing include guards, but I thought
I'd say something anyway.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v22 00/10] Block replication for continuous checkpoints, Wang WeiWei, 2016/07/22
- [Qemu-block] [PATCH v22 01/10] unblock backup operations in backing file, Wang WeiWei, 2016/07/22
- [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint, Wang WeiWei, 2016/07/22
- Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint,
Max Reitz <=
- [Qemu-block] [PATCH v22 03/10] Backup: export interfaces for extra serialization, Wang WeiWei, 2016/07/22
- [Qemu-block] [PATCH v22 06/10] auto complete active commit, Wang WeiWei, 2016/07/22
- [Qemu-block] [PATCH v22 04/10] Link backup into block core, Wang WeiWei, 2016/07/22
- [Qemu-block] [PATCH v22 07/10] Introduce new APIs to do replication operation, Wang WeiWei, 2016/07/22
- [Qemu-block] [PATCH v22 05/10] docs: block replication's description, Wang WeiWei, 2016/07/22