[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] fix incorrect identify implementation in nvme
|
From: |
Keith Busch |
|
Subject: |
Re: [Qemu-block] fix incorrect identify implementation in nvme |
|
Date: |
Thu, 4 Aug 2016 16:14:29 -0400 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote:
> Third resent of this series after this didn't get picked up the
> previous times. The Qemu NVMe implementation mistakes the cns
> field in the Identify command as a boolean. This was never
> true, and is actively harmful since NVMe1.1 (which the Qemu
> device claims to support) supports more than two Identify variants.
>
> We had to add a quirk in Linux to work around this behavior.
Yes, these are great. Do we need to ping a maintainer to go through
their tree, or can this be applied immediately? If need be, I can apply
and send a pull request.