Re: [Qemu-block] [PATCH v3 8/9] vl: Switch qemu_uuid to QemuUUID

[Jeff Cody]

On Wed, Aug 10, 2016 at 09:28:56AM +0800, Fam Zheng wrote:
> On Tue, 08/09 17:45, Jeff Cody wrote:
> > > diff --git a/util/uuid.c b/util/uuid.c
> > > index 80c89f0..5d8bc88 100644
> > > --- a/util/uuid.c
> > > +++ b/util/uuid.c
> > > @@ -61,18 +61,19 @@ char *qemu_uuid_unparse_strdup(const QemuUUID *uuid)
> > >                             uu[13], uu[14], uu[15]);
> > >  }
> > >  
> > > -int qemu_uuid_parse(const char *str, uint8_t *uuid)
> > > +int qemu_uuid_parse(QemuUUID *uuid, const char *str)
> > 
> > Wait, what's going on here?  Why switch the argument order away from the
> > libuuid order?
> 
> I don't see a strong reason to strictly follow libuuid, and thought it would 
> be
> more nature to put the output first, but since it's a surprise to you, I can
> change it back.
>

I just wasn't sure if it was intentional (since it wasn't in the commit
message, and it was a difference from v2).  If you feel strongly about
changing the order, I can be OK with it too :)