qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v3] qemu-img: change opening method


From: Reda Sallahi
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v3] qemu-img: change opening method for the output in dd
Date: Fri, 19 Aug 2016 21:06:08 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Aug 16, 2016 at 12:09:06PM +0100, Stefan Hajnoczi wrote:
> On Mon, Aug 15, 2016 at 02:11:49PM +0200, Reda Sallahi wrote:
> > +    blk2 = blk_new_open(image_opts ? NULL : out.filename,
> > +                        NULL, qoptions, BDRV_O_RDWR, NULL);
> 
> This code duplicates a subset of img_open().  Why can't you use
> img_open() or at least img_open_opts()/img_open_file()?

If I used img_open() here (or img_open_opts()/img_open_file() for that
matter) it would have written on stderr that the file couldn't be opened
here even though in this case it's not error if we can create the output
image and open it later on.

-- 
Reda




reply via email to

[Prev in Thread] Current Thread [Next in Thread]